fix(android): update reject overrides to use nullable code param for …#85
Merged
mountiny merged 2 commits intoJun 15, 2026
Conversation
…RN 0.84+ compatibility
|
All contributors have signed the CLA ✍️ ✅ |
Contributor
Author
|
I have read the CLA Document and I hereby sign the CLA |
JakubKorytko
previously approved these changes
Jun 12, 2026
JakubKorytko
left a comment
JakubKorytko
left a comment
Collaborator
There was a problem hiding this comment.
LGTM. The only thing I'd consider is applying the code ?: "..." fallback consistently, but it's optional polish, not a blocker.
There was a problem hiding this comment.
Pull request overview
Updates the Android Promise implementation in Utils.getAsyncResult to match React Native 0.85’s updated Promise.reject overload signatures (where the code parameter is now nullable), fixing a compile-time override mismatch when building against RN 0.85.3.
Changes:
- Updated
Promise.reject(...)overrides inUtils.ktto acceptcode: String?to align with RN 0.85’s interface.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
mountiny
approved these changes
Jun 15, 2026
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
RN 0.85 updated the Promise interface in react-native so that the code parameter in all reject overrides is now String? (nullable) instead of String. This change updates Utils.kt to match the new interface signatures, fixing a compilation error when building with RN 0.85.3.
Related Issues
Expensify/App#91629
Manual Tests
Build the Android app with RN 0.85.3 - previously failed to compile due to signature mismatch, now builds successfully.
Linked PRs
Expensify/App#92484
https://github.com/Expensify/Mobile-Expensify/pull/13959